TLDR: I think there are still plenty of life left with Intel Mac and if one is looking to purchase an Mac on a budget, Intel MacBook Pros are still offers values that can't be matched by Apple Silicon Macs.
So the writing is on the wall now, macOS Tahoe is the last release for Intel and Apple is done with Apple. Whether or not this is good thing or if Apple dropped Intel too soon, it is up to debate and I don't think there will ever be agreement. So this left two questions:
1. Should Intel MacBook Pro users abandon ship and upgrade.
2. Should anyone purchase Intel MacBook right now.
I have every generation of Intel MacBook Pro from 2009 with exception of 2018 and 2020 version. For Apple Silicon Macs, I have M1 MacBook Pro, M1 MacBook Air, M2 MacBook Air, M1, M2 and M3 Mac mini. So I have plenty experiences with Intel Mac and Apple Silicon Macs.
So let's talk about the two questions, at least in my opinion:
1. Should Intel MacBook Pro users abandon ship and upgrade?
The short answer is yes, if you have the budgets. Apple Silicon MacBook Pro offers better performance than Intel MacBooks and it runs much cooler, battery life is certainly better than Apple Silicon MacBook Pro.
But it doesn't mean that every Intel MacBook Pro users should just throw their MacBook Pro and shell out for Apple Silicon MacBook Pros. I am typing this on an 2017 MacBook Pro 15" with Core i7 Processor, 16GB of RAM, 500GB of SSD, brand new battery for little over $250USD. I am able to install macOS Sequoia with OCLP, run BlackMagic davinci resolve for video editing, doing office work, enjoying movies or TV shows without any issues.
In opinion, for Intel MacBook Pro users, if don't need the most updated Mac or your workflow is fine with Intel MacBook Pro, I don't think upgrading Apple Silicon Mac would dramatically improve your experience in meaningful manner (maybe battery life is better). But if you have the budget and/or your workflow requires more powerful hardwares, then by all means upgrade.
Let's talk about support.
I have macOS Sequoia installed on all MacBook Pro from 2013 onwards. I can honestly say, Sequoia runs perfectly fine. This is meanly due to insignificant performance uplifting from Intel's Haswell to Coffee Lake processor. OCLP is very straight forward and requires very minimum amount of maintaining. So for most Intel MacBook Pro users (expect 2019 16" and 13" wth four Thunderbolt ports), there are two more years of software support.
2. Should anyone purchase Intel Macs
Lots of people in this forum or reddit think purchasing Intel Mac in 2025 is not a good idea and they are probably have point. M1 MacBook Air or M1 MacBook Pros have became cheaper in 2025 and some 16" M1 MacBook Pro are less than $1000 USD on eBay. You would be right, for the same amount of money, you should choose Apple Silicon MacBook over Intel.
But it doesn't mean Intel MacBook Pro aren't worth to purchase. Depends on your usage, some 2016-2018 MacBook Pro were selling less than $300 and for regular users, these laptop are sufficient enough for everyday usage.
Intel MacBook Pros also provides more flexibility than Apple Silicon MacBook Pros. Older Intel MacBooks from Retina generations to TouchBar generation, are all compatible with EFI. So installing Windows on these machine is pretty easy. Booting of Linux distribution is also possible. So these machines are cheap enough for kids, regular people who are not need lots of computing needs, or simply looking for a cheap Mac.
But keep in mind, no-one should go buy Unibody MacBook Pros (2009-2012, non-retina), as these machines are very old. Sonoma and Sequoia aren't work well with these machines.
So, as most people in this forum are transition away from Intel MacBook Pros, I still hold on lots of my Intel MacBook Pros. I think there are lots of usefulness and you can do lot with these Intel MacBook Pros.